Try not allowing string iteration #59683

RyanCavanaugh · 2024-08-19T17:05:12Z

Trial for #59676 to see what happens in real world code

RyanCavanaugh · 2024-08-19T17:05:26Z

jakebailey · 2024-08-19T17:07:19Z

typescript-bot · 2024-08-19T17:07:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	👀 Results

MichaelMitchell-at · 2024-08-19T18:11:09Z

We actually had an incident related to this recently and patched String a few weeks ago!

jakebailey · 2024-08-19T18:15:11Z

Oh hey, the self test is actually catching a bug:

Error: src/server/editorServices.ts(4962,25): error TS2769: No overload matches this call.
  Overload 1 of 2, '(iterable?: Iterable<string> | null | undefined): Set<string>', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'Iterable<string>'.
  Overload 2 of 2, '(values?: readonly string[] | null | undefined): Set<string>', gave the following error.
    Argument of type 'string' is not assignable to parameter of type 'readonly string[]'.

jakebailey · 2024-08-19T18:17:41Z

The rest are strange string manipulation stuff which feels moderately dubious when it comes to "properly" handling indexes:

Error: src/harness/fourslashImpl.ts(2594,43): error TS2345: Argument of type 'string' is not assignable to parameter of type 'Iterable<unknown>'.
Error: src/harness/fourslashImpl.ts(2595,38): error TS18046: 'char' is of type 'unknown'.
Error: src/harness/fourslashImpl.ts(2603,51): error TS2345: Argument of type 'string' is not assignable to parameter of type 'Iterable<unknown>'.
Error: src/harness/fourslashImpl.ts(2603,69): error TS2345: Argument of type '(char: string) => boolean' is not assignable to parameter of type '(value: unknown, index: number, obj: unknown[]) => unknown'.
  Types of parameters 'char' and 'value' are incompatible.
    Type 'unknown' is not assignable to type 'string'.
Error: src/harness/fourslashImpl.ts(2604,56): error TS2345: Argument of type 'unknown[]' is not assignable to parameter of type 'readonly string[]'.
  Type 'unknown' is not assignable to type 'string'.
Error: src/harness/fourslashImpl.ts(2604,69): error TS[23](https://github.com/microsoft/TypeScript/actions/runs/10457724694/job/28958003929?pr=59683#step:7:24)45: Argument of type 'string' is not assignable to parameter of type 'Iterable<unknown>'.
Error in build-src in 23s
Error: Process exited with code: 2
Completed build-src with errors in 23s

MichaelMitchell-at · 2024-08-19T18:24:16Z

Oh hey, the self test is actually catching a bug:

This is almost the exact same kind of bug we had. In our case we were spreading a string instead of an array of string.

MichaelMitchell-at · 2024-08-19T18:27:15Z

Oh hey, the self test is actually catching a bug:

This is almost the exact same kind of bug we had. In our case we were spreading a string instead of an array of string.

Also fun times, if you have an argument spread that's too large you may get a stack overflow

typescript-bot · 2024-08-19T19:33:09Z

@jakebailey Here are the results of running the top 800 repos with tsc comparing main and refs/pull/59683/merge:

Something interesting changed - please have a look.

Details

adobe/react-spectrum

9 of 15 projects failed to build with the old tsc and were ignored

packages/@spectrum-icons/illustrations/tsconfig.types.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/@internationalized/number/src/NumberFormatter.ts#L199
- packages/@internationalized/number/src/NumberParser.ts#L292

ben-rogerson/twin.macro

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2488: Type 'string | (string | string[])[] | [string | (string | string[])[]]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/core/lib/defaultTailwindConfig.ts#L69
error TS2488: Type 'string | string[] | [string | string[]]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/core/lib/defaultTailwindConfig.ts#L86

bitwarden/clients

21 of 57 projects failed to build with the old tsc and were ignored

libs/vault/tsconfig.spec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/vault/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/tools/send/send-ui/tsconfig.spec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/tools/send/send-ui/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/tools/export/vault-export/vault-export-ui/tsconfig.spec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/tools/export/vault-export/vault-export-ui/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/importer/tsconfig.spec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/importer/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/auth/tsconfig.spec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

libs/auth/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- libs/components/src/form-field/bit-validators/forbidden-characters.validator.ts#L15

Chocobozzz/PeerTube

6 of 12 projects failed to build with the old tsc and were ignored

packages/types-generator/tsconfig.types.json

error TS2322: Type '{ defaultSrc: string[]; connectSrc: string[]; mediaSrc: string[]; fontSrc: string[]; imgSrc: string[]; scriptSrc: string[]; scriptSrcAttr: string[]; styleSrc: string[]; objectSrc: string[]; formAction: string[]; ... 4 more ...; workerSrc: string[]; } & (({ ...; } | { ...; }) & ({ ...; } | { ...; }))' is not assignable to type 'Record<string, Iterable<ContentSecurityPolicyDirectiveValue> | unique symbol>'.
- server/core/middlewares/csp.ts#L33 in server/tsconfig.types.json
error TS2322: Type '({ defaultSrc: string[]; connectSrc: string[]; mediaSrc: string[]; fontSrc: string[]; imgSrc: string[]; scriptSrc: string[]; scriptSrcAttr: string[]; styleSrc: string[]; objectSrc: string[]; formAction: string[]; ... 4 more ...; workerSrc: string[]; } & (({ ...; } | { ...; }) & ({ ...; } | { ...; }))) & { ...; }' is not assignable to type 'Record<string, Iterable<ContentSecurityPolicyDirectiveValue> | unique symbol>'.
- server/core/middlewares/csp.ts#L38 in server/tsconfig.types.json

packages/tests/tsconfig.json

error TS2322: Type '{ defaultSrc: string[]; connectSrc: string[]; mediaSrc: string[]; fontSrc: string[]; imgSrc: string[]; scriptSrc: string[]; scriptSrcAttr: string[]; styleSrc: string[]; objectSrc: string[]; formAction: string[]; ... 4 more ...; workerSrc: string[]; } & (({ ...; } | { ...; }) & ({ ...; } | { ...; }))' is not assignable to type 'Record<string, Iterable<ContentSecurityPolicyDirectiveValue> | unique symbol>'.
- server/core/middlewares/csp.ts#L33 in server/tsconfig.lib.json
error TS2322: Type '({ defaultSrc: string[]; connectSrc: string[]; mediaSrc: string[]; fontSrc: string[]; imgSrc: string[]; scriptSrc: string[]; scriptSrcAttr: string[]; styleSrc: string[]; objectSrc: string[]; formAction: string[]; ... 4 more ...; workerSrc: string[]; } & (({ ...; } | { ...; }) & ({ ...; } | { ...; }))) & { ...; }' is not assignable to type 'Record<string, Iterable<ContentSecurityPolicyDirectiveValue> | unique symbol>'.
- server/core/middlewares/csp.ts#L38 in server/tsconfig.lib.json

continuedev/continue

8 of 9 projects failed to build with the old tsc and were ignored

binary/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- core/autocomplete/charStream.ts#L79

curlconverter/curlconverter

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/shell/Word.ts#L71
- src/shell/Word.ts#L133

desktop/desktop

1 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- app/src/lib/git/interpret-trailers.ts#L57
- app/src/lib/truncate-with-ellipsis.ts#L9

discordjs/discord.js

45 of 62 projects failed to build with the old tsc and were ignored

apps/website/tsconfig.json

error TS2488: Type 'Selection' must have a '[Symbol.iterator]()' method that returns an iterator.
- apps/website/src/components/ui/PackageSelect.tsx#L75

apps/website/tsconfig.eslint.json

error TS2488: Type 'Selection' must have a '[Symbol.iterator]()' method that returns an iterator.
- apps/website/src/components/ui/PackageSelect.tsx#L75

dream-num/univer

39 of 57 projects failed to build with the old tsc and were ignored

packages/sheets-thread-comment-base/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/sheets-sort/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/sheets-hyper-link/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/sheets-filter/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/sheets/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/engine-formula/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

packages/data-validation/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/engine-formula/src/functions/math/decimal/index.ts#L110

ether/etherpad-lite

src/tsconfig.json

error TS2488: Type '"*:%"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/tests/backend/specs/SecretRotator.ts#L133
error TS2488: Type '"-:@_.,~%+/?=&#!;()[]$'*"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/tests/frontend-new/specs/urls_become_clickable.spec.ts#L24
error TS2488: Type '":.,;?!)]'*"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/tests/frontend-new/specs/urls_become_clickable.spec.ts#L40

faker-js/faker

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
error TS2488: Type '"._-"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/modules/internet/index.ts#L104
error TS2488: Type '".!#$%&'*+-/=?^_{|}~"' must have a 'Symbol.iterator' method that returns an iterator.`
- src/modules/internet/index.ts#L105
error TS2488: Type '"ABCDEFGHIJKLMNOPQRSTUVWXYZ"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/modules/string/index.ts#L7
error TS2488: Type '"abcdefghijklmnopqrstuvwxyz"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/modules/string/index.ts#L8
error TS2488: Type '"0123456789"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/modules/string/index.ts#L9

getumbrel/llama-gpt

ui/tsconfig.json

error TS2322: Type 'String' is not assignable to type 'ReactI18NextChildren'.
- ui/components/Chat/ErrorMessageDiv.tsx#L16
error TS2322: Type 'String' is not assignable to type 'ReactNode'.
- ui/components/Chat/ErrorMessageDiv.tsx#L20
- ui/components/Chat/ErrorMessageDiv.tsx#L24

gitkraken/vscode-gitlens

3 of 4 projects failed to build with the old tsc and were ignored

src/webviews/apps/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/plus/focus/focusProvider.ts#L615
error TS2488: Type 'string | string[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/uris/deepLinks/deepLinkService.ts#L953

hexojs/hexo

tsconfig.json

error TS2488: Type 'string | Set<any>' must have a '[Symbol.iterator]()' method that returns an iterator.
- lib/plugins/renderer/nunjucks.ts#L17

immich-app/immich

2 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- server/src/entities/user-metadata.entity.ts#L49

server/tsconfig.build.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- server/src/entities/user-metadata.entity.ts#L49

immutable-js/immutable-js

1 of 4 projects failed to build with the old tsc and were ignored

tests/tsconfig.json

error TS2345: Argument of type 'string' is not assignable to parameter of type 'Iterable<unknown>'.

javascript-obfuscator/javascript-obfuscator

jhipster/generator-jhipster

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.types.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

jupyterlab/jupyterlab

46 of 59 projects failed to build with the old tsc and were ignored

examples/filebrowser/src/tsconfig.json

error TS2307: Cannot find module '@jupyterlab/codemirror' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L25 in examples/filebrowser/src/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/fileeditor' or its corresponding type declarations.
- examples/filebrowser/src/index.ts#L33 in examples/filebrowser/src/tsconfig.json
error TS7006: Parameter 'language' implicitly has an 'any' type.
- examples/filebrowser/src/index.ts#L99 in examples/filebrowser/src/tsconfig.json
- examples/filebrowser/src/index.ts#L102 in examples/filebrowser/src/tsconfig.json

examples/console/src/tsconfig.json

error TS2307: Cannot find module '@jupyterlab/codemirror' or its corresponding type declarations.
- examples/console/src/index.ts#L26 in examples/console/src/tsconfig.json
error TS2307: Cannot find module '@jupyterlab/console' or its corresponding type declarations.
- examples/console/src/index.ts#L28 in examples/console/src/tsconfig.json
error TS7006: Parameter 'theme' implicitly has an 'any' type.
- examples/console/src/index.ts#L96 in examples/console/src/tsconfig.json
error TS7006: Parameter 'extensionFactory' implicitly has an 'any' type.
- examples/console/src/index.ts#L102 in examples/console/src/tsconfig.json
error TS7006: Parameter 'options' implicitly has an 'any' type.
- examples/console/src/index.ts#L108 in examples/console/src/tsconfig.json
error TS7006: Parameter 'language' implicitly has an 'any' type.
- examples/console/src/index.ts#L123 in examples/console/src/tsconfig.json
- examples/console/src/index.ts#L126 in examples/console/src/tsconfig.json

kysely-org/kysely

3 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/query-compiler/default-query-compiler.ts#L1672

tsconfig-cjs.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/query-compiler/default-query-compiler.ts#L1672

mapbox/mapbox-gl-js

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

microsoft/azuredatastudio

11 of 67 projects failed to build with the old tsc and were ignored

extensions/markdown-language-features/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts#L410

extensions/markdown-language-features/tsconfig.browser.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts#L410

extensions/git/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/git/src/repository.ts#L1163

microsoft/inshellisense

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

microsoft/playwright

5 of 16 projects failed to build with the old tsc and were ignored

packages/recorder/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/playwright-core/src/utils/isomorphic/stringUtils.ts#L121

microsoft/vscode-extension-samples

1 of 71 projects failed to build with the old tsc and were ignored

drop-on-document/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- drop-on-document/src/extension.ts#L33

microsoft/vscode

4 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
error TS2488: Type '"~!@#$%^&*()-=+[{]}\|;:'",.<>/?"' must have a 'Symbol.iterator' method that returns an iterator.`
- src/vs/editor/common/core/wordHelper.ts#L39
error TS2769: No overload matches this call.
- src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts#L46

src/tsconfig.monaco.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
error TS2488: Type '"~!@#$%^&*()-=+[{]}\|;:'",.<>/?"' must have a 'Symbol.iterator' method that returns an iterator.`
- src/vs/editor/common/core/wordHelper.ts#L39

src/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
error TS2488: Type '"~!@#$%^&*()-=+[{]}\|;:'",.<>/?"' must have a 'Symbol.iterator' method that returns an iterator.`
- src/vs/editor/common/core/wordHelper.ts#L39
error TS2769: No overload matches this call.
- src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts#L46
- src/vs/workbench/services/editor/test/browser/customEditorLabelService.test.ts#L41

extensions/markdown-language-features/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts#L249

extensions/markdown-language-features/tsconfig.browser.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts#L249

extensions/git/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- extensions/git/src/repository.ts#L1177

build/tsconfig.build.json

error TS2488: Type 'string | string[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- build/lib/i18n.ts#L369

motion-canvas/motion-canvas

14 of 18 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/core/src/tweening/interpolationFunctions.ts#L9
- packages/core/src/tweening/interpolationFunctions.ts#L10

packages/core/tsconfig.build.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/core/src/tweening/interpolationFunctions.ts#L9
- packages/core/src/tweening/interpolationFunctions.ts#L10

mui/material-ui

23 of 83 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

error TS2488: Type '"hsla(220, 30%, 5%, 0.7) 0px 4px 16px 0px, hsla(220, 25%, 10%, 0.8) 0px 8px 16px -5px" | "hsla(220, 30%, 5%, 0.07) 0px 4px 16px 0px, hsla(220, 25%, 10%, 0.07) 0px 8px 16px -5px"' must have a '[Symbol.iterator]()' method that returns an iterator.
- docs/data/material/getting-started/templates/dashboard/theme/themePrimitives.ts#L227

neoclide/coc.nvim

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

NG-ZORRO/ng-zorro-antd

6 of 11 projects failed to build with the old tsc and were ignored

components/tsconfig.spec.json

error TS2769: No overload matches this call.
- components/time-picker/time-picker-panel.component.ts#L244

nodejs/nodejs.org

apps/site/tsconfig.json

error TS2488: Type '"" | RegExpMatchArray' must have a '[Symbol.iterator]()' method that returns an iterator.
- apps/site/util/stringUtils.ts#L2

pillarjs/path-to-regexp

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/index.ts#L99

tsconfig.build.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/index.ts#L99

pixijs/pixijs

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.types.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/scene/text-bitmap/BitmapFontManager.ts#L186
- src/scene/text/canvas/CanvasTextMetrics.ts#L130

pubkey/rxdb

8 of 11 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2769: No overload matches this call.
- src/plugins/utils/utils-object-dot-prop.ts#L19
error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/plugins/utils/utils-object-dot-prop.ts#L27

config/tsconfig.types.json

error TS2769: No overload matches this call.
- src/plugins/utils/utils-object-dot-prop.ts#L19
error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/plugins/utils/utils-object-dot-prop.ts#L27

raineorshine/npm-check-updates

tsconfig.json

error TS2488: Type 'never[] | "global"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/package-managers/pnpm.ts#L100
error TS2488: Type 'string | never[]' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/package-managers/pnpm.ts#L102

typescript-bot · 2024-08-19T19:33:09Z

@jakebailey Here are some more interesting changes from running the top 800 repos suite

Details

reduxjs/redux-toolkit

14 of 35 projects failed to build with the old tsc and were ignored

packages/toolkit/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- packages/toolkit/src/query/tests/devWarnings.test.tsx#L62
- packages/toolkit/src/query/tests/devWarnings.test.tsx#L122

refined-github/refined-github

tsconfig.json

error TS2488: Type '"🚀🐿️⚡️🤌🥳🥰🤩🥸😎🤯🚢🛫🏳️🏁"' must have a '[Symbol.iterator]()' method that returns an iterator.
- source/features/quick-review.tsx#L18
error TS2488: Type 'string[] | ""' must have a '[Symbol.iterator]()' method that returns an iterator.
- source/github-helpers/banner.tsx#L35
error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- source/helpers/hash-string.ts#L4

shadcn-ui/ui

7 of 9 projects failed to build with the old tsc and were ignored

packages/cli/tsconfig.json

error TS2345: Argument of type 'String' is not assignable to parameter of type 'string | ArrayBufferView | Iterable<string | ArrayBufferView> | AsyncIterable<string | ArrayBufferView> | Stream'.
- packages/cli/src/commands/add.ts#L180

sindresorhus/got

tsconfig.json

error TS2345: Argument of type 'string' is not assignable to parameter of type 'Iterable<any> | AsyncIterable<any>'.

tusen-ai/naive-ui

3 of 6 projects failed to build with the old tsc and were ignored

src/tsconfig.demo.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/code/src/Code.tsx#L190 in src/tsconfig.demo.json
- src/input/src/utils.ts#L6 in src/tsconfig.demo.json

vadimdemedes/ink

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/parse-keypress.ts#L213

vscode-neovim/vscode-neovim

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/highlights/grid_line_handler.ts#L135
- src/test/integ/integrationUtils.ts#L149
error TS2488: Type '"<BS><Cmd><LT><BS><BS><Right><Return>hello<Enter>"' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/test/integ/dot-repeat.test.ts#L99

VSCodeVim/Vim

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.

wandb/openui

frontend/tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- frontend/src/lib/webauthn.ts#L15

yoavbls/pretty-ts-errors

tsconfig.json

error TS2488: Type 'string' must have a '[Symbol.iterator]()' method that returns an iterator.
- src/format/addMissingParentheses.ts#L16

Try not allowing string iteration

e945262

typescript-bot assigned RyanCavanaugh Aug 19, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 19, 2024

jakebailey mentioned this pull request Aug 19, 2024

Fix Set of one string literal bug in openExternalProject #59686

Merged

RyanCavanaugh closed this Aug 19, 2024

RyanCavanaugh mentioned this pull request Aug 19, 2024

Add --strictObjectIterables (bikeshed): exclude primitive (string) from Iterable types #59676

Open

6 tasks

Try not allowing string iteration #59683

Try not allowing string iteration #59683

Uh oh!

Conversation

RyanCavanaugh commented Aug 19, 2024

Uh oh!

RyanCavanaugh commented Aug 19, 2024

Uh oh!

jakebailey commented Aug 19, 2024

Uh oh!

typescript-bot commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelMitchell-at commented Aug 19, 2024

Uh oh!

jakebailey commented Aug 19, 2024

Uh oh!

jakebailey commented Aug 19, 2024

Uh oh!

MichaelMitchell-at commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelMitchell-at commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 19, 2024

Uh oh!

typescript-bot commented Aug 19, 2024

typescript-bot commented Aug 19, 2024 •

edited

Loading

MichaelMitchell-at commented Aug 19, 2024 •

edited

Loading

MichaelMitchell-at commented Aug 19, 2024 •

edited

Loading